test: Run one blockchain test at a time - #1690
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors blockchain execution to process one test per runner invocation.
Changes:
- Replaces span-based execution with a single-test API.
- Moves file-level iteration into the CLI caller.
- Simplifies failure locations by removing redundant case indexes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/utils/blockchaintest.hpp |
Declares the single-test runner. |
test/utils/blockchaintest_runner.cpp |
Refactors execution for one test. |
test/unittests/blockchaintest_runner_test.cpp |
Adopts the new API. |
test/blockchaintest/blockchaintest.cpp |
Iterates tests at file level. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
+ Coverage 97.94% 97.98% +0.03%
==========================================
Files 181 181
Lines 16216 16211 -5
Branches 3729 3729
==========================================
+ Hits 15883 15884 +1
+ Misses 252 248 -4
+ Partials 81 79 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
test/blockchain-run-one
branch
from
September 1, 2026 14:29
b56458f to
d5b0489
Compare
chfast
force-pushed
the
test/blockchain-run-one
branch
from
September 1, 2026 14:45
d5b0489 to
d989fa9
Compare
A test which gave up took the rest of its file with it: the early returns left the loop over the whole span, so every test after it never ran. Taking one test lets the caller which has the file's tests do the loop. The index in the failure place goes with the loop, since the case name above it already says which case failed.
chfast
force-pushed
the
test/blockchain-run-one
branch
from
September 1, 2026 15:04
d989fa9 to
d957fc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test which gave up took the rest of its file with it: the early
returns for an invalid block or a requests mismatch left the loop over
the whole span, so every test after it silently never ran. Taking one
test lets the caller which has the file's tests do the loop instead.
The index in the failure place goes with the loop, since the case name
above it already says which case failed: places read
Cancun/2ratherthan
Cancun/7/2. Most of the diff is the de-indent;git diff -wonthe runner is 36 lines added and 55 removed.