test: Count outcomes from the notes - #1693
Merged
Merged
Conversation
Contributor
Every test which did not pass leaves exactly one note, so the counts follow from the notes and need no counters of their own, and a skip's reason is a reason like any other. Claude-Session: https://claude.ai/code/session_016UHPAGwcwXMjqhTLpT31K7
chfast
force-pushed
the
test/count-from-notes
branch
from
September 2, 2026 06:02
0be7124 to
aeeaf69
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1693 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 181 181
Lines 16211 16198 -13
Branches 3729 3724 -5
=======================================
- Hits 15884 15872 -12
Misses 248 248
+ Partials 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The refactor is consistent with existing invariants and test coverage.
Pull request overview
Simplifies test outcome accounting by deriving counts from recorded notes.
Changes:
- Removes redundant outcome counters and switch.
- Stores skip reasons directly.
- Derives passed, failed, and skipped totals after execution.
File summaries
| File | Description |
|---|---|
test/utils/test_driver.cpp |
Simplifies outcome tracking while preserving reporting behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every test which did not pass leaves exactly one note, so the counts follow from the notes: the three counters and the switch feeding them go, and a skip's reason is stored like any other. Peeled out of #1685, where it was a rewrite of #1684 code hiding inside "add the command".