evm: Improve readability of SELFDESTRUCT refund - #1694
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The refactor is behaviorally equivalent and covered by existing refund tests.
Pull request overview
Refactors SELFDESTRUCT refund handling for readability without changing behavior.
Changes:
- Names the host result
first_time. - Combines nested refund conditions.
File summaries
| File | Description |
|---|---|
lib/evmone/instructions.hpp |
Simplifies SELFDESTRUCT refund logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 181 181
Lines 16199 16199
Branches 3724 3723 -1
=======================================
Hits 15873 15873
Misses 248 248
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.