Repository navigation
Avoid NPE when joining/editing group with deleted owner - #837
Merged
Merged
Conversation
The owner summary of a group can validly be null, if the group owner's account has been archived/deleted. As long as the summary is null both before and after the change, this check should pass.
The other instances of this message are already debug-level logs, and since this is a valid state for a group to be in there is no need to log an error here.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 41.69% 41.63% -0.06%
==========================================
Files 550 552 +2
Lines 23684 23759 +75
Branches 2868 2884 +16
==========================================
+ Hits 9874 9892 +18
- Misses 12915 12969 +54
- Partials 895 898 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
If the group owner has been archived/deleted, getOwnerSummary() returns null. If a null user is included in this response, the frontend doesn't handle it properly and the group join fails. We might as well just not add the null user at all.
Allow for the case where the group owner is null.
axlewin
changed the title
axlewin
commented
Sep 22, 2026
jsharkey13
reviewed
Sep 30, 2026
Co-authored-by: James Sharkey <jsharkey13@users.noreply.github.com>
jsharkey13
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A group can be in a valid state where its owner's account has been archived or deleted but it is still being used by additional manager(s). Therefore the endpoints to join and edit groups need to be able to cope with
group.getOwnerSummary()being null.