You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Release v1: editable About page and rollout readiness - #139
Completes the v1 rollout with an editable About page and verifies the current release across the workspace. /about uses the shared public Markdown renderer; administrators can preview and publish title, description, and content from /admin/about, with stale-edit protection and an unsaved-changes guard.
Add About API contracts, authorization, singleton persistence, migration, navigation, metadata, sitemap entry, and generated package exports.
Keep initial catalogue pagination consistent across SSR and hydration, index category ancestry lookups, cancel deleted-category query variants together, and replace deprecated client/chart APIs.
Consolidate advertising and ranking documentation into the existing guides, synchronize the PRD and roadmap, and prepare changelog notes covering changes since v0.7.1.
Update regression coverage for Recommended sorting, About endpoints, custom OpenAPI error statuses, verified bookmark projections, 45-slot pagination, and current project-card markup. Flush pending React work in editor/navigation fixtures and allow the search test's debounce and route-pending delays to complete.
Validation on the final working tree:
vp check: formatting, lint, and type-aware checks pass with zero warnings/errors.
vp run typecheck: all 8 workspace configurations pass.
All unit/integration suites across server, web, API, auth, DB, shared, and UI: 1,730 tests pass. Database suites use disposable local test schemas.
vpx react-doctor@latest --verbose --scope changed --include-untracked: 100/100, no new findings.
Browser suite: 20 files, 121 tests pass.
HTTP acceptance passes for auth, bookmarks, reports, featured projects, ownership, licenses, SEO/production packaging, and categories. Email delivery is mocked; no live mail is sent. SEO includes 16 check groups and category acceptance includes 6.
Production recursive build passes. Existing non-blocking bundle-size and Shiki import warnings remain.
The optional live Upstash integration test is not run because dedicated development credentials are not configured. It is excluded from the passing test count.
Before deployment, apply the additive About migration with vp run db:migrate; its reserved-slug preflight must pass. Deploy matching API/web revisions. Changelog notes remain under Unreleased until the actual version is tagged.
Summary by CodeRabbit
New Features
Added a public About page with an admin editor for updating its content.
Added About page links to site navigation and included the page in the sitemap.
Added customizable confirmation and cancellation button labels to dialogs.
Bug Fixes
Improved category lookups and deletion handling, and corrected catalogue loading behavior.
Updated upload error responses to report expired uploads and promotion conflicts with appropriate statuses.
Documentation
Updated release, deployment, architecture, and development guidance for the About page and other product features.
- Add public About page with SEO metadata and sitemap coverage
- Add admin editor with Markdown preview, validation, and conflict handling
- Persist About content through API and database
This pull request adds public and admin About pages with versioned updates. It also changes category lookups and deletion behavior, catalogue offsets, and v1 release documentation. Supporting updates adjust navigation, API fixtures, and tests.
Changes
About Page Publishing
Layer / File(s)
Summary
About page data and persistence packages/shared/src/schemas/about.ts, packages/db/src/schemas/about.ts, packages/db/src/migrations/*, packages/shared/src/constants/index.ts, docs/prd.md
The shared package defines About page schemas, types, and default content. The database adds a singleton about_page table. Project slugs now reserve about. The PRD specifies About page access and content requirements.
About API and revision handling packages/api/src/contracts/about.ts, packages/api/src/routers/about.ts, packages/api/src/contracts/index.ts, packages/api/src/routers/index.ts, packages/api/tests/about.test.ts
The API adds public and admin About endpoints. Admin updates use expected versions and return a conflict when the stored revision does not match. Tests cover reads, updates, authorization, validation, and concurrent writes.
Public and admin About pages apps/web/src/features/about/*, apps/web/src/routes/_app/about.tsx, apps/web/src/routes/_main/admin.about.tsx, apps/web/src/routeTree.gen.ts, apps/web/src/components/header.tsx, apps/web/src/components/footer.tsx, apps/web/src/components/main-sidebar-content.tsx, apps/web/src/components/workspace-header.tsx, apps/web/src/components/action-confirmation.tsx, apps/web/src/features/seo/sitemap.server.ts, apps/web/tests/about.test.tsx, apps/web/tests/admin-about-editor.test.tsx, apps/web/tests/browser/about.browser.tsx
The public route renders About content, and the admin route provides an editor with validation, previews, navigation blocking, and conflict handling. Navigation and the sitemap include About routes. Tests cover rendering, editing, and browser behavior.
Category and Catalogue Behavior
Layer / File(s)
Summary
Indexed category labels and ancestry apps/web/src/features/admin-categories/model.ts, apps/web/src/features/admin-categories/components/*, apps/web/src/components/category-combobox-view.tsx, apps/web/tests/category-model.test.ts
Category ancestry and labels now accept arrays or ID-indexed maps. Category forms, tables, and the combobox build and use an index. Tests cover duplicate IDs, missing parents, cycles, and input order.
Category deletion and detail queries apps/web/src/features/admin-categories/queries.ts, apps/web/tests/category-catalog-ui.test.tsx
Category deletion cancels and removes queries matching either category detail key. The test checks cancellation, late responses, query state, and navigation.
The catalogue offset hook uses useSyncExternalStore with client and server snapshots. Documentation describes directory display slots and offsets. Acceptance tests update category-card assertions and pagination fixtures.
The release notes and product documents describe editorial publishing, advertising, ranking, and v1 acceptance. The standalone advertising and ranking documents are removed.
Architecture and deployment guidance docs/architecture.md, docs/deployment.md, docs/development.md
The guides document advertising selection and operations, email delivery, monitoring, and test coverage. Architecture documentation also describes request handling, ranking, private order access, and uploads.
Compatibility and supporting test updates packages/api/tests/*, packages/api/tests/fixtures/openapi-wire-contract.json, packages/shared/tests/*, packages/ui/src/components/chart.tsx, apps/web/tests/*
Supporting changes update OpenAPI error responses, oRPC client types, sort expectations, and tests for bookmarks, licenses, and retries. The chart legend uses Recharts’ position prop; test helpers and fixtures also change.
sequenceDiagram
participant AboutRoute
participant AboutRouter
participant AboutDatabase
AboutRoute->>AboutRouter: Request public or admin About data
AboutRouter->>AboutDatabase: Select the About page
AboutDatabase-->>AboutRouter: Stored page or no row
AboutRouter-->>AboutRoute: Page data or default About page
AboutRoute->>AboutRouter: Submit update with expectedVersion
AboutRouter->>AboutDatabase: Insert or update matching revision
AboutDatabase-->>AboutRouter: Updated page or no matching row
AboutRouter-->>AboutRoute: Updated page or conflict
LoadingPre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the main changes: the editable About page and v1 rollout readiness. It is concise, specific, and related to the changeset.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 14 functions across 49 files. (12 skipped: 12 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Review coverage is incomplete: 1 file could not be fully reviewed. Findings from completed review steps are included; see review info for details.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the v1 rollout with an editable About page and verifies the current release across the workspace.
/aboutuses the shared public Markdown renderer; administrators can preview and publish title, description, and content from/admin/about, with stale-edit protection and an unsaved-changes guard.v0.7.1.Validation on the final working tree:
vp check: formatting, lint, and type-aware checks pass with zero warnings/errors.vp run typecheck: all 8 workspace configurations pass.vpx react-doctor@latest --verbose --scope changed --include-untracked: 100/100, no new findings.The optional live Upstash integration test is not run because dedicated development credentials are not configured. It is excluded from the passing test count.
Before deployment, apply the additive About migration with
vp run db:migrate; its reserved-slug preflight must pass. Deploy matching API/web revisions. Changelog notes remain under Unreleased until the actual version is tagged.Summary by CodeRabbit