Repository navigation
fix: resolve build import and chunk-size warnings - #146
Conversation
- Apply text styling when each custom theme is imported - Split editor and Shiki language chunks and tune chunk warnings - Load API auth statically while keeping the database dynamic
- Use a Ruby grammar without its embedded C++ dependency - Keep C++ code blocks readable as plain text
|
No actionable comments were generated in the recent review. WalkthroughThe web app adds custom Ruby language registrations, removes C++ highlighting registrations, and changes built-in theme loading. The client build adds dependency split groups. The API context changes how it imports auth and db. ChangesShiki Language and Theme Registrations
Client Build Splitting
API Context Imports
Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk:
|
|
React Doctor found 1 new issue in 1 file · 1 warning · score 87 / 100 (Great) · 0 fixed · vs Reviewed by React Doctor for commit |
| ]) | ||
| const { db } = await import('@altstack/db') | ||
|
|
||
| const session = await auth.api.getSession({ headers }) |
There was a problem hiding this comment.
React Doctor · react-doctor/server-sequential-independent-await (warning)
This awaited initializer does not read the previous result. If the operations are independent asynchronous work, they may overlap; await syntax alone does not establish a speedup.
Fix → Consider Promise.all([...]) only for independent asynchronous work. Shared queues or synchronous work may not benefit. Preserve resource limits, transaction ordering, and failure/cancellation semantics.
Production builds reported ineffective dynamic imports for auth and Shiki themes, plus oversized client chunks. Use consistent imports and split React, editor, and language dependencies while retaining the default 500 kB warning threshold.
Remove C++ highlighting, including Ruby's transitive C++ grammar. Load the pinned upstream Ruby grammar with its remaining embedded languages so Ruby highlighting still works and existing C++ code blocks remain readable as plain text.
Validation:
Summary by CodeRabbit