Use readable Playwright page fixtures - #21
Merged
Conversation
commit: |
mmkal
marked this pull request as ready for review
August 4, 2026 12:20
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7ab36b7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Make Middlewright's checked-in Playwright examples read like normal Playwright tests:
page, with the original fixture aliased tobasePageexpectcallsNo public API or runtime behavior changes.
Review notes
The first commit records scope and assumptions. The FFmpeg boundary check now samples the first stable decoded frame because removing a redundant locator matcher also removes its incidental startup delay.
Verification
pnpm typecheckpnpm buildCI=1 pnpm test— 101 passed, 4 skipped, 1 flaky test passed on retrypnpm exec playwright test spec/todo-app.spec.tsVisual baseline
Rendered
spec/todo-app.spec.ts:video-rendered.webm
Codex session:
019fcc8a-c39a-7940-8df7-85cb34080ca3Note
Low Risk
Test and documentation-only changes with no runtime or API modifications; risk is limited to spec behavior if observation waits were mis-scoped.
Overview
Aligns checked-in specs, README snippets, and demo code with the documented Playwright style: the Playwright fixture is
basePage, the plugin-wrapped handle ispage(replacingplugged), and UI outcomes use locator actions andwaitFor()instead of redundantexpectmatchers.expectremains for metadata, timings, paths, and other non-UI values. Some video-mode specs usebasePagefor observation-only waits so checks do not become recorded middleware actions on the enhanced page.writing-middlewright-tests.mdand the completed task note mirror the same conventions; no publicaddPluginsAPI changes.Reviewed by Cursor Bugbot for commit f90e921. Bugbot is set up for automated code reviews on this repo. Configure here.