Repository navigation
Define the midplane loci by maximum major radius - #39
Merged
Merged
Conversation
…stry plan Records the lead's ruling of 2026-10-22. The midplane loci take one definition: the low-field-side maximum-major-radius point of the flux surface, with the inboard midplane at the high-field-side minimum. This replaces the per-dataset identifier wording, which made the locus sentence contradict any name taken at a stated height. poloidal_angle keeps its zero on the axis plane.
The outboard and inboard midplane loci were defined by a per-dataset midplane height, selected by the data with the magnetic-axis height as the fallback. That is not one definition: a name whose quantity is taken at a stated height reads two heights. The outboard midplane is now the point on the flux surface in question of maximum major radius, on the low-field side, and the inboard midplane the point of minimum major radius on the high-field side. The equational relation is R = max_S R with R > R_axis, and R = min_S R with R < R_axis. outboard_midplane_separatrix is the separatrix reaching its maximum major radius, on the low-field side. poloidal_angle keeps its zero on the horizontal plane through the magnetic axis and now states that this zero coincides with the outboard midplane only for up-down-symmetric equilibria. No locus definition names a data-dictionary field, IDS path or option value; the physics-only test still excludes them. The relation test asserts the major-radius relation for outboard_midplane, inboard_midplane and outboard_midplane_separatrix, and the concept equations for the two midplanes. It fails on the previous height wording and on a definition that drops the relation.
The landing record lists every changed definition before and after, the two red controls (the previous per-dataset height wording, and a planted definition dropping the major-radius relation) and the tests/grammar gate at base and head.
…c3): not-run Record the landing: append the run to the project ledger and its plan comment in one commit, so a promotion leaves the checkout without uncommitted state at the paths it wrote.
…c3): record workspace outcome Record the worktree and process release receipt after promotion without rewriting a commit another session may have published.
Section 10 is declared done. The midplane loci carry one maximum-major-radius definition, recorded with its review and its test counts; the release and the downstream pin follow.
Record the landing: append the run to the project ledger and its plan comment in one commit, so a promotion leaves the checkout without uncommitted state at the paths it wrote.
…utcome Record the worktree and process release receipt after promotion without rewriting a commit another session may have published.
The concept and locus registries now give the midplane loci one definition, the low-field-side maximum and high-field-side minimum of the flux surface's major radius, replacing the per-dataset identifier wording. poloidal_angle keeps its zero on the plane through the magnetic axis and states that it coincides with the outboard midplane only for up-down-symmetric equilibria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines the midplane loci once, by the flux surface's major-radius extremum, replacing the per-dataset midplane-identifier wording.
outboard_midplane: the point on the low-field side where the flux surface reaches its maximum major radius. On the separatrix, that is its outboard maximum-R point.inboard_midplane: the corresponding point of minimum major radius on the high-field side.outboard_midplane_separatrix: the separatrix's outboard maximum-R point.poloidal_anglekeeps its zero on the horizontal plane through the magnetic axis, and now states that this zero coincides with the outboard midplane only for up-down-symmetric equilibria.Why. The per-dataset wording let the generic locus sentence contradict any name whose quantity is taken at a stated height. Reviewers read two heights in the same document. The new definition keeps both concerns of the previous change: it holds for a limited plasma, whose last closed flux surface still has a maximum-R point, and the poloidal-angle convention is unchanged.
Tests. The physics-only definition test keeps passing. Its relation test now asserts the maximum-R and minimum-R relations, and fails on the previous wording.
tests/grammar/: 1285 passed against 1282 at base, with no added failures.Evidence: definition change and controls.