Repository navigation
Preserve RK recovery backoff through brief symplectic probes - #619
Merged
Merged
Conversation
krystophny
marked this pull request as ready for review
October 23, 2026 16:16
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
krystophny
marked this pull request as draft
October 23, 2026 17:13
krystophny
force-pushed
the
fix/rk-recovery-stuck
branch
from
October 23, 2026 17:16
a070e5c to
ddca162
Compare
krystophny
force-pushed
the
fix/rk-recovery-stuck
branch
from
October 23, 2026 19:16
ddca162 to
aa1fb46
Compare
krystophny
marked this pull request as ready for review
October 23, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIMPLE cleared RK recovery history after one accepted symplectic microstep. If the next attempt failed, recovery restarted with the shortest cooldown and could repeatedly probe the same difficult region. Treat the first accepted symplectic step as provisional and clear the history after the second consecutive accepted step.
An accepted step counts after wall and collision checks. A failed attempt, including an unresolved hold or collision rollback, interrupts the provisional streak while retaining recovery history. The first accepted step still clears the stale recovery momentum reference. Recovery thresholds, tolerances, energy bounds and golden references are unchanged.
The regression exercises both macrostep paths. It checks retention after one accepted step, clearing after two, and interruption by failed attempts, unresolved holds and collision rejection. The previous source fails the new interruption assertion; the candidate passes.
Validation on aa1fb46, based on main fb81524:
.capture,.locksand.statedirectories as generations. Controller and independent review accepted the preserved numerical evidence without rerunning tests or changing the failed receipt. This covers the selected 147-case gate, not all 211 registered cases.The unchanged recovery policy also passed bounded paired diagnostic job 3361418 before rebasing onto the formatting-only main update. Both protected Albert/Meiss orbit comparisons passed, with identical inputs, starts and marker exit statuses: each public case retained 15 completed trajectories and 17 physical LCFS losses. The 16-start, 0.1-second Drevlak pair retained 11 completed trajectories, two physical LCFS losses and three starts skipped by the existing strongly-passing rule (code 3), with zero NaN loss times or numerical exit statuses. Those three starts were assumed confined and were not traced. In this bounded pair, activations changed from 11,952 to 9,330, field evaluations from 367,437,373 to 348,868,024, and tracing time from 153.356 s to 141.372 s.
Chris&AI