Repository navigation
Reset default spectral proposals between native initializations - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated GVEC initialization can inherit the preceding VMEC input’s spectral defaults and sine/cosine parity. Four local proposal variables have declaration initializers, which give them implicit SAVE semantics in Fortran. Reset the same proposals on every initialization, preserving explicit input choices and VMEC/boundary-derived overrides.
The regression reads an existing synthetic asymmetric VMEC input, then checks the default spectral range and the analytic circle’s four independent normal traces. No private fixture, numerical tolerance or equation changes. This is the lower prerequisite for the separate converter state-persistence repair #18.
Slurm3362324 qualified integrated50895d4a: original default1 and converter4 cases fail before their respective repairs, repaired5/5 pass, full1314Python tests pass (31existing skips,36expected failures), and all17native tests pass in clean resident generation18b62645be5677bdf71c9f125cfe1ce97634b98d1bfa84255bd5bb2f1f7cd95a. Private Fo/runtime pre/post identities match and owner exit is verified. Final canonicalcae1ac53 has the identical qualified tree4c1356a2afad489bd14fa99f13ba2a98eff6d97e.
Source181f26ed was squash-merged as3aefb809 and retained in archive/pr19-source-20261024. The genuine standalone upstream repair remains draft MR195. Later optional test-collection integration is tracked separately in #20; no failed CI receipt is relabelled.
Chris&AI