Skip to content

fix: strip ranges of PR numbers from release notes (RS1) - #47

Merged
itsdoubleem merged 1 commit into
mainfrom
fix/review-2026-11-11
Nov 11, 2026
Merged

itsdoubleem merged 1 commit into
mainfrom
fix/review-2026-11-11

Conversation

@itsdoubleem

Copy link
Copy Markdown
Owner

What

Release notes lose ranges of pull-request numbers — "(#47–#50)", "(#46, #51–#53)" — the way they already lost "(#31)" and "(#31 and #32)". LOGGER 1.7.0's "What's new" had two, live on /apps/logger/.

Why

They link nowhere on this site, and cleanNotes()'s own comment says they are removed. Its pattern had no case for a range.

How

  • tools/sync-lib.mjs: each item in the bracket may be #N or a range #N–#M / #N-M (hyphen, en or em dash).
  • releases/logger.md: rebuilt with notesFile(cleanNotes(...)) from the real v1.7.0 Release body. Only the two brackets went; its source: fingerprint is what the sync computes, so the next hourly run reports both apps current and writes nothing.

Testing

Screenshots

Text only — the two "What's new" paragraphs end at "inside." and "for 9 seconds." instead of with PR numbers.

Risks and rollback

A bracket like "(#1-3)" in future notes would also be stripped. Rollback: git push --force-with-lease origin 19627d7:main.

@itsdoubleem
itsdoubleem merged commit 994677b into main Nov 11, 2026
1 check passed
@itsdoubleem
itsdoubleem deleted the fix/review-2026-11-11 branch November 11, 2026 11:32

This branch was previously deployed

1 inactive deployment
github-pages — 994677b2 Deployed Nov 11, 2026 by itsdoubleem via deploy #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant