Skip to content

COMMIT="$(git rev-list -1 HEAD)" in /daemon/References/Linux/scripts/build-daemon.sh is blocking compilation #585

Description

@najjara

Bug report

Describe your environment

  • Device: PC
  • OS name and version: Arch Linux kernel 7.1.4
  • IVPN app version: 3.15.13

Describe the problem

I have IVPN for Linux installed through AUR. PKGBUILD does some Arch specific tweaking, but essentially it's still the official tarball.
When trying to build the latest version it fails at line 158 ./build-daemon.sh $@ in /daemon/References/Linux/scripts/build.all with the error:

======================================================
============ Compiling IVPN service ==================
======================================================
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
==> ERROR: A failure occurred in build().
    Aborting...

Command 'sudo --user=#1000 -- makepkg --force' failed to execute.

The offending line is COMMIT="$(git rev-list -1 HEAD)" in /daemon/References/Linux/scripts/build-daemon.sh introduced in this latest version as part of the support for ARM64: https://github.com/ivpn/desktop-app/blame/development/daemon/References/Linux/scripts/build-daemon.sh

The issue can is also reproducible when installing from the official tarball directly without AUR.

Steps to reproduce:

  1. Download and untar the 3.15.13 tarball
  2. ./cli/References/Linux/build.sh in src dir (alternatively just run git rev-list -1 HEAD in the dir and get the same error)
  3. Error, failure to compile

Observed Results:

Failure to compile.
Since the src dir is missing .git git doesn't recognize it as a valid dir and won't perform rev-list. Transplanting the .git from git clone solves the issue.

Relevant Code:

Line 36 in /daemon/References/Linux/scripts/build-daemon.sh

./daemon/References/Linux/scripts/build-daemon.sh

or

git rev-list -1 HEAD

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions