Fix boolean pattern metrics after reload - #8
Open
SH1RLEYyang wants to merge 1 commit into
Open
SH1RLEYyang wants to merge 1 commit into
SH1RLEYyang wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, schema-driven, and covered by a targeted round-trip test that demonstrates the intended behavior.
Pull request overview
This PR fixes a type regression in MMEAF deserialization where pattern slot metric values (stored as XML attributes) were always decoded as strings after reload, causing boolean metrics (checkboxes) to come back as "true"/"false" instead of true/false.
Changes:
- Add schema-aware decoding for
mm:metric_valueentries so boolean metrics are parsed as booleans based on their metric schema. - Build a
metricTypeslookup map from parsed pattern schemas and reuse it when parsing patterns and pattern-related suggestions. - Add a round-trip test ensuring boolean metric values are restored as booleans while text metrics remain strings.
File summaries
| File | Description |
|---|---|
| packages/serialization/src/mmeaf-parse.ts | Decode mm:metric_value attributes using the metric schema type (boolean vs string). |
| packages/serialization/tests/mmeaf-roundtrip.test.ts | Add coverage proving boolean metrics survive emit→parse as booleans (and text "true" stays a string). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.