test: characterize transcoding contracts and models - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This is PR 1 of the hardware-transcoding implementation sequence. It is deliberately observational and foundational: it locks current public behavior and introduces the type/test seams required by later runtime, probing, planning, and hardware-backend PRs. It does not enable the new hardware-transcoding path.
The follow-up
transcoding/02-jellyfin-runtimebranch is stacked on this exact commit history, so this PR should use a normal merge commit rather than squash or rebase merge.Verification
cargo fmt --all -- --checkcargo clippy -p fake-media-tool --all-targets -- -D warningscargo clippy -p server --no-default-features --features librqbit --all-targets -- -D warningscargo test -p fake-media-tool— 27 passedcargo test -p server --no-default-features --features librqbit -- --test-threads=1— 81 passed, 2 intentionally ignored characterization/download testsFollow-up
After this merges and CI is green, the Jellyfin FFmpeg runtime-foundation PR will be retargeted to
masterso its diff contains only Tasks 4–6.