Fix stale Coveralls badge and re-wire coverage upload - #20
Merged
Conversation
The badge pointed at the wrong repo entirely (jakehadar/bikeshare-client, missing "-python") on a branch=coverage that isn't the default branch - Coveralls had nothing to render regardless of upload activity. Separately, nothing has uploaded coverage data since Travis CI was removed; the old .travis.yml ran `coveralls` in after_success, and its replacement (Test workflow) only prints a local coverage report, never sends it anywhere. - Point the badge at the correct repo slug and master branch - Add a coverage.py -> lcov -> coverallsapp/github-action upload step, gated to a single matrix leg (3.13) to avoid submitting 6 conflicting reports for the same commit - Uses the Coveralls GitHub App integration (GITHUB_TOKEN), no separate repo token secret needed Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Coveralls badge hasn't updated since ~2019 for two separate reasons:
jakehadar/bikeshare-client(missing-python) onbranch=coverage, not this repo's actual slug or default branch. Even with fresh data flowing, this badge would never have rendered it..travis.ymlrancoverallsinafter_success; when Travis was replaced with GitHub Actions, nothing replaced that upload step. TheTestworkflow computes coverage locally (coverage report -m) but never sends it anywhere.Changes
jakehadar/bikeshare-client-pythononbranch=master.github/workflows/test.yml: generates an lcov report viacoverage lcov, uploads viacoverallsapp/github-action@v2GITHUB_TOKEN) rather than a stored repo token secretBefore merging
Repo must be enabled on coveralls.io first: log into coveralls.io with GitHub, use the GitHub App integration to add
bikeshare-client-python. Without that, the upload step will fail (nothing to receive the report).Test plan
coverage lcov -o coverage.lcovproduces a valid LCOV report locally (Python 3.8, coverage.py 7.6.1)🤖 Generated with Claude Code