Conversation
|
리뷰 완료 — Blocker 0건, Major 0건, Minor 3건, Question 0건 |
f1v3-dev
force-pushed
the
f1v3/refactor-zk-status-check-delete
branch
from
September 11, 2026 07:24
f8e3dea to
edef589
Compare
|
리뷰 완료 — Blocker 0건, Major 0건, Minor 2건, Question 0건 |
f1v3-dev
force-pushed
the
f1v3/refactor-zk-status-check-delete
branch
from
September 15, 2026 02:04
edef589 to
6cbf5f4
Compare
ruok over SSH before deletion
Collaborator
Author
|
삭제 전 상태 확인 방식을
|
|
리뷰 완료 — Blocker 0건, Major 0건, Minor 0건, Question 1건 [Question] |
namsic
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
zk delete의 디렉터리 존재 검사를 제거하여, 원격 디렉터리가 이미 삭제된 경우에도 정리할 수 있도록 변경합니다.ruok를 실행하여 삭제 전 연결 상태를 확인하도록 변경합니다.zk delete의 오류를RunE로 반환하도록 변경하고, CLI 오류가 중복 출력되지 않도록 정리했습니다.