fix(suggest-relations): #778 carry the direction disclaimer on both surfaces - #786
Merged
Merged
Conversation
…urfaces An asymmetric relation type's direction carries no evidence (#613), and docs/testing.md documents the '(direction model-suggested, unverified)' suffix as the contract -- but only curate's Structure stage spelled it. suggest-relations, the surface that most invites bulk application, now renders the same suffix on the read-only listing line and on --apply's preview and [y/N] prompt. One shared helper (_direction_caveat) owns the spelling for all three surfaces so they cannot drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/testing.mddocuments(direction model-suggested, unverified)as the contract wherever a suggested relation direction is presented — but onlycurate's Structure stage spelled it.suggest-relations, the surface that most invites bulk application, showed confident types with inverted directions (two of 24 proposals in the E2E run contradicted their own rationale) and no caveat.caused_by,depends_on,member_of,part_of,produced_by).--applycarries it on both the preview line and theRelate … [type] (…)? [y/N]prompt — mirroringcurateexactly._direction_caveat) now owns the spelling for all three surfaces;curateconsumes it too, so they cannot drift.docs/cli.mdupdated.Verification
ruff,ruff format --check,mypy .clean.review-c844282418f82be5approved (4R; 0 blocking findings, first-round approval). Gates pre-commit/pre-pr allow.Closes #778
🤖 Generated with Claude Code
https://claude.ai/code/session_011rKLjyxsEZJtZWDCeozZhs