Skip to content

fix(build): use spotless to format gradle files - #2706

Closed
wfouche wants to merge 6 commits into
jbangdev:mainfrom
wfouche:dev/spotless-gradle
Closed

wfouche wants to merge 6 commits into
jbangdev:mainfrom
wfouche:dev/spotless-gradle

Conversation

@wfouche

@wfouche wfouche commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Standardized formatting across the Gradle build configuration.
    • Grouped plugin repository and resolution settings under plugin management while retaining the existing plugin module resolution.
    • Removed the test help-width override.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The build adds Spotless formatting for build.gradle and settings.gradle. settings.gradle moves plugin repositories and the namespace-specific resolution rule into pluginManagement. Other build expressions are reformatted without changing their existing values or conditions.

Changes: Gradle build setup

Layer / File(s) Summary
Plugin resolution and Gradle formatting
build.gradle, settings.gradle
settings.gradle scopes plugin repositories and the module resolution rule under pluginManagement. build.gradle configures Spotless with the Groovy Gradle formatter, trailing-whitespace trimming, and a final newline for both scripts. Existing expressions and lists are reformatted without changing their values or conditions. The aesh.help.width=80 test property and inactive commented settings were removed.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: maxandersen, cstamas

Merge Risk: Minimal · up to 1844e

This change adds Spotless formatting for the Gradle scripts and moves plugin repositories and resolution rules into pluginManagement. No concrete regression was found, so it looks ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(build): use spotless to format gradle files" matches the main change. The PR makes Spotless format build.gradle and settings.gradle with the Groovy Gradle formatter, and it moves plugin…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(build): use spotless to format gradle files" matches the main change. The PR makes Spotless format build.gradle and settings.gradle with the Groovy Gradle formatter, and it moves plugin repositories and resolutionStrategy into pluginManagement. The title is specific and concise. It uses a conventional-commit style prefix, which is acceptable.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 37699e7 and 1844e4f.

Files selected for processing: 1

  • build.gradle

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@wfouche wfouche closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant