Skip to content

fix(build): use spotless to fornat gradle files - #2708

Open
wfouche wants to merge 1 commit into
jbangdev:mainfrom
wfouche:dev/spotless-groovy-gradle
Open

wfouche wants to merge 1 commit into
jbangdev:mainfrom
wfouche:dev/spotless-groovy-gradle

Conversation

@wfouche

@wfouche wfouche commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated build and project configuration formatting and organization. Existing test, packaging, and plugin behavior remains unchanged.
  • Refactor
    • Removed an inactive packaging configuration option. No user-facing functionality changed.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Gradle scripts add Spotless formatting for Gradle files and move repository and resolution strategy blocks under pluginManagement. Existing build settings are reformatted, and commented-out configuration is removed.

Changes: Gradle Script Updates

Layer / File(s) Summary
Formatter and plugin resolution
build.gradle, settings.gradle
Spotless adds Greclipse formatting for both Gradle scripts. The repositories and plugin resolution strategy move inside pluginManagement.
Build script settings
build.gradle
Test, packaging, checksum, token replacement, native-image, and Allure settings are reformatted. Commented-out shadowJar minimization and test snippets are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: maxandersen, cstamas

Merge Risk: Minimal · up to 19e3c

This change adds Gradle file formatting and reorganizes plugin repository configuration without altering build behavior. No actionable merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title says the PR uses Spotless to format Gradle files, which matches the changeset. Spotless gains a groovyGradle formatter for build.gradle and settings.gradle, and both files are reformatted. T…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title says the PR uses Spotless to format Gradle files, which matches the changeset. Spotless gains a groovyGradle formatter for build.gradle and settings.gradle, and both files are reformatted. The title has a typo, 'fornat' instead of 'format'. It also uses the 'fix(build):' prefix, but the changes are mainly formatting and tooling, so the prefix is only a minor concern. The title is concise and identifies the primary change.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e5af0ea and 19e3c3f.

Files selected for processing: 2

  • build.gradle
  • settings.gradle

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant