Repository navigation
ReusableOptimizer: don't overwrite better paths from other processes - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #90, from the comment on #89.
With
overwrite="improved",ReusableOptimizercompared new paths against its own in-memory copy of the cache entry, never the disk. With several processes sharing a cache directory, one process could replace a better path written by another with a worse one.update_from_tree(which defaults to"improved") had the same problem.Changes:
DiskDict.gethas a newrefresh=Falseoption, to read from disk even if the key is in memory. If the disk read fails, it falls back to the memory copy.ReusableOptimizeruses it just before the"improved"comparison, in both_maybe_run_optimizer(after the optimizer run) andupdate_from_tree.overwrite=Falseandoverwrite=Trueare unchanged.The extra read costs about 10–20 µs on a local disk, compared with ms to seconds for the optimizer run that
"improved"mode already does on every call.