Repository navigation
Wait for the pdf-diff compare to finish before counting highlights - #4
Merged
Merged
Conversation
The summary appears before the pages are redrawn with highlights, so the multi-page test could count the overlay while it was still empty on a slow runner (CI run 44215751195). It now waits until the compare finishes.
jesse-anderson
temporarily deployed
to
github-pages
November 18, 2026 04:04 — with
GitHub Pages
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-page test read the highlight overlay as soon as the summary appeared, but the tool shows the summary before it redraws the pages with highlights. On a slow runner the overlay was still empty (CI run 44215751195, pdf-diff.spec.cjs:299). The test now polls window.pdfDiffState.isProcessing until the compare finishes.
Verified by adding a temporary 500 ms delay to renderPage: the old test failed at line 299, the fixed one passed. Test-only change; all 13 pdf-diff tests pass.