chore(build): exclude patchedDependencies from target pnpm workspace - #1980
Open
paustint wants to merge 1 commit into
Open
chore(build): exclude patchedDependencies from target pnpm workspace#1980paustint wants to merge 1 commit into
paustint wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Electron build script to make the target workspace truly self-contained by excluding root-only pnpm patch configuration that would break in the copied build directory.
Changes:
- Removes
patchedDependenciesfrom the derived targetpnpm-workspace.yamlconfig. - Keeps the target workspace isolated by continuing to reset
packagesto an empty list.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Drop `patchedDependencies` too: it points at files under the root `patches/` directory, | ||
| // which isn't copied into TARGET_DIR, and the patched packages (e.g. dev-only lint tooling) | ||
| // aren't part of the desktop build's dependency set anyway. | ||
| const { patchedDependencies, ...targetWorkspace } = rootWorkspace; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.