Repository navigation
fix: hardening from the code review - #51
Merged
Merged
Conversation
A failed save cleared the unsaved mark, so leaving the field never tried again and quitting could lose the text. The note now stays unsaved until a save works.
Clipboard images were served with the one-hour cache of icons, so the webview could keep a deleted or hidden image on disk. They are now no-store; icons keep their cache.
The card read checked secret markers and then read the text in two GTK requests; a newer copy between them could show text whose markers were not checked. Both replies now need the owner they started with.
An older download for the same city (A, then B, then A again) could end the newer one's busy state. Each download now has a number, and only the latest may store its result.
A failure to restrict tinydash.db to the user only reached the log. It now shows as a launcher warning that says what to do; the data still opens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Fixes from an outside code review (ChatGPT, at
f6bb1e1), after checking each finding against the code. One commit per fix:Cache-Control: no-store; icons keepmax-age=3600clipboard_text()drops both GTK replies when the clipboard owner changes between them, as capture doesWeatherAttempt::startNot done on purpose:
A related issue the review missed is fixed in #48: a rates download that ended after rates were turned off saved them again.
Commands run
bun run verify