Export and import application versions - #102
Merged
Merged
Conversation
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Contributor
asafgabai
commented
Sep 14, 2026
asafgabai
added
the
safe to test
asafgabai
marked this pull request as ready for review
September 14, 2026 11:37
github-actions
Bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
SaharBracha
reviewed
Sep 14, 2026
| return true, errorutils.CheckErrorf("application version export failed: %s", status.Message) | ||
| case exportStatusCompleted: | ||
| return true, nil | ||
| default: |
Collaborator
There was a problem hiding this comment.
keep polling on STARTED / NOT_TRIGGERED; only fail on FAILED or unknown.
Collaborator
Author
There was a problem hiding this comment.
Added NOT_TRIGGERED (AFAIK there's no STARTED status)
SaharBracha
reviewed
Sep 14, 2026
| return commonCLiCommands.Exec(eac) | ||
| } | ||
|
|
||
| func parseExportDownloadFlags(ctx *components.Context) (minSplitSize int64, splitCount int, err error) { |
Collaborator
There was a problem hiding this comment.
Consider rejecting negatives (non -1)
Collaborator
Author
There was a problem hiding this comment.
This parameter is owned by jfrog-client-go and is widely used across many commands in JFrog CLI. The right place to handle that is there, but I think it's out of the scope of this PR.
SaharBracha
reviewed
Sep 14, 2026
SaharBracha
approved these changes
Sep 14, 2026
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainbranch.go vet ./....go fmt ./....