fix(client): set --accent-rgb with --accent, and use the variables index.css defines - #180
Merged
Merged
Conversation
…dex.css defines app.jsx and AdminPanel set --accent at runtime but never --accent-rgb, so every rgba(var(--accent-rgb), x) tint stayed on the stylesheet's default purple while solid accent followed the pick. WidgetContainer hardcoded a pink alpha for the selection glow and eleven other sites hardcoded the purple one, so three accent hues could be on screen at once. One helper now writes all four variables in both places, and every alpha tint reads --accent-rgb. --text-color, --text-muted and --text-primary are not defined anywhere; index.css defines --text and --text-secondary. Every use was on `color`, so the invalid declaration computed to inherit and mostly looked right by accident. The one visible case was the color picker's hex input, whose #000 fallback sat on the dark card. Same root cause as the chore-metrics fix in HomeGlowPlugins: the vocabulary of the retired substitute stylesheet had leaked into core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app.jsxand the Admin Panel preview set--accentat runtime but never--accent-rgb, so everyrgba(var(--accent-rgb), x)tint stayed on the stylesheet's default purple while solid accent followed the pick. One helper,applyInterfaceColors, now writes all four variables in both places, with unit tests for the hex triplet.WidgetContainerhardcoded a pink alpha and eleven other sites hardcoded the purple one. All 14 now readrgba(var(--accent-rgb), x), so one accent hue is on screen.--text-color(23 uses),--text-muted(4) and--text-primary(1) are not defined anywhere;index.cssdefines--textand--text-secondary. Every use was oncolor, so it computed toinheritand mostly looked right by accident. The visible case was the color picker's hex input, whose#000fallback sat on the dark card. Same root cause as HomeGlowPlugins Major update to main #13.Testing
Client: 306 tests,
check:i18n,vite build. Running on our production display since 2026-09-16.