fix(chore-metrics): use the core --text variable, not --text-color - #13
Merged
jherforth merged 1 commit intoSep 15, 2026
Merged
Conversation
--text-color is not defined by client/src/index.css, which is the stylesheet plugins link as /index.css. It came from a hardcoded substitute the backend served whenever it could not find the real file — which was always, in any container deployment, because the backend image cannot contain client source. That substitute used a different vocabulary, and this is the only plugin written against it. With the real stylesheet now served, --text-color resolves to nothing and the declared fallback #333 applies: dark grey text on --card-bg #2a2a2a. The core name is --text. The literal fallback stays as-is; it only applies if the stylesheet fails to load entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to jherforth/HomeGlow#175, which fixes jherforth/HomeGlow#174 — that PR makes the real stylesheet reach plugin iframes for the first time, which is what retires
--text-color. Safe to merge before it: while the old substitute is still being served neither name resolves here, so the declared#333fallback applies either way.--text-color is not defined by client/src/index.css, which is the stylesheet plugins link as /index.css. It came from a hardcoded substitute the backend served whenever it could not find the real file which was always, in any container deployment, because the backend image cannot contain client source. That substitute used a different vocabulary, and this is the only plugin written against it.
With the real stylesheet now served, --text-color resolves to nothing and the declared fallback #333 applies: dark grey text on --card-bg #2a2a2a. The core name is --text.
The literal fallback stays as-is; it only applies if the stylesheet fails to load entirely.