Conversation
The manifest declares manageCountdowns as a hideable control. When the dashboard names it on the iframe URL, the Add New Countdown button and its form are removed at parse time, the per-item Edit and Delete buttons are left out of the render, and the edit and delete handlers return early. No hide param hides nothing, so an older dashboard and a direct load of the file behave as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Countdown declares
manageCountdownsas a hideable control and readshidefrom its URL at parse time, the same shape as TastyTiles (#12). Under the gate the Add New Countdown toggle and form are removed before first paint, per-item Edit and Delete are not rendered, and their handlers return early. Nohideparam hides nothing, so an older dashboard and a direct load are unaffected.Verified with and without the param on our production display.