Repository navigation
ci: skip merge commits in DCO check - #127
Merged
Merged
Conversation
Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
 [Low impact] This PR appears safe to merge. SummaryThe PR skips merge commits during the pull request DCO check.
Reviews (1) · Last reviewed commit: "ci: skip merge commits in DCO check" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip merge commits when collecting commits for the pull_request DCO check. GitHub's Update branch action adds an unsigned merge commit when synchronizing a pull request with master; that generated integration commit should not fail DCO validation. The check continues to require a Signed-off-by trailer on every non-merge commit. Add a workflow contract test to cover both behaviors.
Related issues
None.
Additional information
Validation:
uv run --locked --no-sync pytest tests/test_ci_test_plan.py::test_dco_check_skips_merge_commits_but_requires_signed_off_by— passed.uv run --locked --no-sync python scripts/pr-precheck.py— passed, including Python 3.12/3.13 CI parity and documentation parity.