Repository navigation
[Core] Honor optional framework-native input routes - #129
Merged
Merged
Conversation
Allow omitted optional input routes without bindings while retaining required route and supplied Dataset checks. Cover optional omission, unbound inputs, and single counting of supplied optional roles. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
 [Medium impact] The PR appears safe to merge; optional omission is allowed without weakening checks on supplied inputs. SummaryFramework Native requests can now omit an optional input route without providing a binding.
No actionable issues found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "[Core] Honor optional framework-native i..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow train-only Framework Native requests to omit an input declared with
FrameworkNativeInputRoute(required=False), such asvalidation. Required routes must still have input bindings, and every Dataset supplied to the trainer must still have a declared route, binding, and prepared input view.Add regression coverage for optional omission and unbound inputs, and verify that supplied optional roles are counted once. There are no public API, serialization, or dependency changes.
Related issues
Related to #121 and tributo-algorithms#7.
Additional information
uv run --locked --no-sync python scripts/pr-precheck.py: passed, including the Python 3.12/3.13 CI unit matrix and documentation gates.