Repository navigation
fix: match cordis.patch.yml name to @jiangzhenguo/dsh-codegraph - #8
Merged
Merged
Conversation
The v1.2.1 rename left the bundle patch importing the unscoped package, so the loader never mounts the plugin. Fixes #7. Co-authored-by: jiangzhenguo <jiangzhenguo@users.noreply.github.com>
1.2.1 shipped the unscoped cordis.patch.yml name. This bugfix follows the repo's patch-bump practice (1.2.0 → 1.2.1). No changelog or lockfile to sync. Co-authored-by: jiangzhenguo <jiangzhenguo@users.noreply.github.com>
jiangzhenguo
marked this pull request as ready for review
October 16, 2026 02:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
v1.2.1 published this package as
@jiangzhenguo/dsh-codegraph(the unscoped npm name was already taken), but the bundle patch still insertedname: dsh-codegraph. That field is the loader's bare-module specifier, not a label: the host resolves and imports it as a package root. After the rename,dsh-codegraphis not installed in the profile, so the insert fails to mount. Install exits cleanly and restarts do not recover it.The patch
namehas to be the same string aspackage.json"name", because that is the module pnpm actually installs. This change sets it to@jiangzhenguo/dsh-codegraph. The entryidis unchanged.Version is bumped 1.2.1 → 1.2.2, matching this repo's patch-bump practice for bugfixes (see
v1.2.1). There is no changelog or lockfile to update.Test plan
cordis.patch.ymlnameis@jiangzhenguo/dsh-codegraph, matchingpackage.json.package.jsonversionis1.2.2.codegraph_*tools.Note
Low Risk
Packaging and bundle metadata only; no runtime logic changes beyond fixing plugin resolution on install.
Reviewed by Cursor Bugbot for commit 6f983e7. Bugbot is set up for automated code reviews on this repo. Configure here.