Add a findings log to the run contract, and accept DL-016 - #41
Draft
jimutt wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 5 <noreply@pi.dev> Generated-By: pi 0.84.2
A run gains a fourth file: findings.md, append-only markdown capturing what the agent noticed that the plan did not anticipate. The agent appends via a dld_run_note tool; the extension surfaces the log on run completion as a transcript card and includes a findings section in the board overlay. Findings are advisory, not gating — a run can complete with findings unaddressed. A finding that blocks the run is a blocker, not a finding. The run contract doc gains a findings.md section. Two new skill scripts (add-finding.sh, get-findings.sh) with bats coverage. The extension registers the tool and the completion card. All suites green: 101 bun, 314 bats. Co-Authored-By: Claude Opus 5 <noreply@pi.dev> Generated-By: pi 0.84.2
This was referenced Aug 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a findings log to the run contract: a fourth file (
findings.md) in the run directory, capturing what the agent noticed during the run that the plan did not anticipate. The agent appends via adld_run_notetool; the extension surfaces the log on run completion as a transcript card and includes a findings section in the board overlay.Findings are advisory, not gating — a run can complete with findings unaddressed. A finding that blocks the run is a blocker, not a finding.
Stacks on
feat/pi-harness-extension, which holds the verified Stage 1 + Stage 2 + rename work. This is the only unverified piece — review focus should be the tool's prompt surface (what the agent is told to record) and whether the completion card is the right amount of detail.All suites green: 101 bun, 314 bats, tsc clean, tessl plugin lint valid.