Repository navigation
fix(theme): make Zellij mouse selections visible again - #35
Merged
Merged
Conversation
In Zellij's flat theme format `black` is the pane background and `bg` only paints mouse selections (and selected rows in its own UI). Every theme set both to the pane colour, so selecting text in a Zellij pane showed no highlight at all. Set `bg` to each theme's Ghostty selection-background colour, generate it that way in theme-new and theme-port, and add a bats test that fails if a theme's `bg` ever equals `black` again. Document the field meaning in docs/theme-system.md and the README theme contract. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
github-actions
Bot
added
type: docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Selecting text with the mouse inside a Zellij pane showed no highlight. In Zellij's flat theme format
blackis the pane background andbgis only used for mouse selections (plus selected rows in its own UI), and every macarchy theme set both to the pane colour. Confirmed against Zellij 0.43.1:text_selected.background = palette.bg,text_unselected.background = palette.black.Changes
zellij.kdl:bgnow takes the theme's Ghosttyselection-backgroundcolour, with a comment explaining the field.theme-newandtheme-portgeneratebgthe same way for new themes.tests/themes.batsfails if any theme'sbgequalsblack.docs/theme-system.mdand the README theme contract note whatbgandblackmean.Verified
ZELLIJ_CONFIG_DIR=<tmp> zellij setup --checkaccepts the new theme file.pre-commit run --files ...passes.theme-new.bats"darken-for-dim rule" slot 6 failure, which also fails on untouchedmain.🤖 Generated with Claude Code