Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
data = {'foo': [[{'a': 1}, {'a': 2}]]}, the expressionfoo[0][:2].acurrently returnsNoneinstead of[1, 2]. A slice following an array index bypasses projection construction, so subsequent expressions are evaluated against the entire sliced list instead of its elements.foo[0] | [:2].aalready produces the expected result, consistent with the documented slice projection behavior.Exclude slices from the optimization that combines consecutive indexes, allowing them to use the existing
_project_if_slicepath. Consecutive scalar indexes retain the optimization.Add 13 compliance cases covering field/root expressions, positive and negative indexes, repeated indexes, reverse and empty slices, missing fields, subsequent array indexes, pipe boundaries, non-array inputs, and null omission. The changelog is updated.
Validation on CPython 3.11.16 under Ubuntu 24.04, using the repository's test dependency versions:
python -m pytest tests -q --cov=jmespath --cov-report=term-missing: 1004 passed, 1 skipped, 99% overall coverage.git diff --check: passed.The full Python/platform CI matrix was not run locally.
Developed with assistance from OpenAI Codex.