Repository navigation
Fix Web Push offline retention and subscription loss - #70
Open
joan-code6 wants to merge 1 commit into
Open
joan-code6 wants to merge 1 commit into
joan-code6 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web Push currently inherits pywebpush's TTL=0, so a push service can accept a message and discard it immediately when the recipient is unavailable. Local signing/configuration exceptions can also delete valid browser subscriptions as if they had expired.
Set retention to 24 hours for messages, one hour for plan changes and ten minutes for test pushes. Remove subscriptions only on explicit push-service 404/410 responses; keep local and transient failures retryable. Document persistent data/key requirements and the session-ownership migration that requires browsers to re-register older endpoints.
Validation: 60 focused notification, authentication recovery, session revocation and dashboard tests pass. Coverage includes a fresh-process SQLite restart, persisted pending deliveries, real pywebpush encryption and outgoing TTL headers against a simulated service, and recovery after signing failure. Fatal-error Ruff checks pass. No production deployment or live push-provider delivery was performed.
Companion browser registration recovery: joan-code6/lanis_ui#99