AIP-12: Add feature spec for Review PR: Reference Resolution & Guide - #263
Draft
jodavis-claude wants to merge 1 commit into
Draft
jodavis-claude wants to merge 1 commit into
jodavis-claude wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item: AIP-12 — Deliverable 1 of the Code Review Helper Detailed Design (parent epic AIP-4): resolves a PR reference to a single target PR, stands up an isolated worktree/clone, gathers evidence, and generates the standalone review guide.
Changes:
_spec_ReviewPrGuide.md, the full implementation-level dev spec for this deliverable./dev-team:review-pr <ref> [prose]command shape, the six-component breakdown (resolve-pr-reference,create-review-worktree,gather-pr-evidence,write-review-guide,review-session-context,decide_cleanup_action.py), and their interfaces.Design decisions:
EnterWorktreetool; cross-repo PRs use a sibling-clonegit worktree addwhen one exists, otherwise a scratchgh repo clone—EnterWorktreehas no notion of an arbitrary other repo.resolve-pr-referenceis a skill wrapping a fully pytest-testable script, plus exactly one inline MCP call for the Jira remote-links lookup (the one step no script in this repo can perform).issue-key-pattern/recognize-patternsrather than callingidentify-project-work-items, since that skill's own ask-the-user fallback doesn't fit this fully-automated (and, forgather-pr-evidence, subagent) context.decide_cleanup_action.py) and the actual tool/CLI action performed byreview-pr, sinceExitWorktree— like the decision logic itself — is only callable from an agent's own tool-use turn.Testing completed: This PR adds the spec only (no implementation yet); the spec itself went through 3 rounds of automated readiness review (
researcher-dev-spec-review) covering component-breakdown completeness, verification-mechanism feasibility, and cross-checks against this repo's actual tool/script capabilities.