AIP-18: Build resolve-pr-reference skill

[jodavis-claude]

Work item: AIP-18 — Build resolve-pr-reference, a skill that resolves a PR reference (bare number/#123, full GitHub PR URL, or a work-item ID) to exactly one owner/repo#number, or a structured not_found/ambiguous/access_denied failure, so every later Code Review Helper deliverable can start from a single resolved PR instead of each re-implementing reference resolution.

Changes:

• plugins/dev-team/skills/resolve-pr-reference/SKILL.md (new) — skill definition documenting the CLI contract, resolution-path priority (full URL → bare number/#123 → work-item-id pattern match, with a context-file check first), the one inline getJiraIssueRemoteIssueLinks tool-use call the skill itself makes for the Jira path before re-invoking the script with --jira-links, and the full JSON success/failure shapes.
• plugins/dev-team/skills/resolve-pr-reference/scripts/resolve_pr_reference.py (new) — the deterministic-path script implementing: full-URL classification; bare-number/#123 classification resolved against the current repo's origin; work-item-id pattern matching against work-tracking.<provider>.issue-key-pattern/recognize-patterns; a use-context-file context-file check that short-circuits provider dispatch when pr_url is already set; the Jira path (remote-links-then-GitHub-search-fallback); the GitHub path (gh api graphql reading closedByPullRequestsReferences); gh pr view existence/access checks shared by the url and number paths; and a thin main() CLI wrapper.
• plugins/dev-team/skills/resolve-pr-reference/scripts/test_resolve_pr_reference.py (new) — colocated pytest suite, 36 tests, all passing, mocking gh/git via subprocess.run.
• plugins/dev-team/skills/work-with-Jira-tasks/SKILL.md (modified) — added the getJiraIssueRemoteIssueLinks row to the Operations table, noting it hits the Remote Issue Links API, not the Development panel's dev-status API.
• plugins/dev-team/skills/work-with-GitHub-issues/SKILL.md (modified) — added the getLinkedPullRequests row to the Common Operations table, noting it's a plain gh api graphql call, not an MCP tool.

Design decisions:

• Canonical work-item-id used for downstream lookups: the script uses ref as given for the context-file lookup (trusting the caller passes the canonical form), and extracts a numeric issue number for the GitHub path via a generic \d+ search rather than an undocumented prefix-reconstruction scheme.
• gh pr view access-denied vs. not-found is decided by a keyword heuristic (403/permission/access/authenticat, case-insensitive) against stderr, since gh's own error text isn't a stable contract.
• GitHub-search fallback implemented as two gh calls merged and deduped by PR number: gh search prs <issue_key> --repo <owner>/<repo> (title/body match) plus gh pr list --repo <owner>/<repo> --state all --json number,headRefName filtered locally for the issue key in headRefName (branch-name match).
• A work-item ID matching a provider other than jira/github (no dispatch logic) is treated as not_found with a clear detail message rather than raising — out of scope for this task but tested so it fails gracefully.
• Plugin version bump (plugins/dev-team/.claude-plugin/plugin.json, currently 1.4.1) was left untouched, pending reviewer/user confirmation on whether it's needed now.

Testing completed:

• python3 -m pytest plugins/dev-team/skills/resolve-pr-reference/scripts/ — 36 tests, all passing, covering every resolution path except the Jira remote-links MCP branch itself (which no script can reach).

[jodavis-claude]

Reviewed against AIP-18's exit criteria and _spec_ReviewPrGuide.md. All 36 pytest tests pass locally (python3 -m pytest plugins/dev-team/skills/resolve-pr-reference/scripts/). Most of the deterministic-path logic (URL, bare number, context-file short-circuit, GitHub getLinkedPullRequests path, gh pr view access/not-found classification) looks correct and well tested.

However, I found a blocking correctness issue in the Jira work-item path: the script has no way to distinguish "--jira-links not supplied yet" (step 1, before the skill has queried Jira) from "--jira-links supplied as an empty array" (step 2, after Jira returned nothing) — both collapse to jira_links=[], so step 1 alone already runs the GitHub-search fallback and returns a terminal result before getJiraIssueRemoteIssueLinks is ever called. See inline comments for details and a couple of secondary reliability notes (unbounded gh pr list/gh search prs result pages, silently swallowed JSON-decode errors).

[jodavis-claude]

Sign-off review — AIP-18: resolve-pr-reference

All 4 prior review threads addressed satisfactorily and resolved:

1. jira_links tri-state collapse (Priority 1 — correctness) — Fixed. _resolve_jira_work_item now distinguishes jira_links is None (not yet supplied) from jira_links == [] (supplied, empty), returning a new needs_jira_links status instead of eagerly running the GitHub-search fallback. Verified with the new mock_run.assert_not_called() test.
2. SKILL.md step 1/2 instructions (Priority 1/4 — correctness & documentation) — Fixed together with #1; steps now key off the real status: "needs_jira_links" value instead of a nonexistent source field.
3. Missing --limit on gh search prs/gh pr list (Priority 1/3 — reliability) — Fixed. Both calls now pass --limit 100; verified by a new flag-presence test.
4. Silent except json.JSONDecodeError: pass (Priority 1 — fault tolerance) — Fixed. _github_search_fallback now returns (matches, warnings), surfacing a specific warning into the final not_found detail instead of swallowing it silently.

Re-ran the full suite: python3 -m pytest plugins/dev-team/skills/resolve-pr-reference/scripts/ — 40/40 passing.

Scanned the 3 files modified since the last review push (resolve_pr_reference.py, SKILL.md, test_resolve_pr_reference.py) for new issues — none found. The diff is scoped tightly to the 4 flagged issues, with no unrelated changes.

Sign-off: approved.