feat: fail the gate when a trigger is recorded but unroutable - #9
Merged
Conversation
Moving routing keywords out of `triggers` and into `description` left the metadata copy as a second source of truth with nothing keeping the two in step. A trigger that lives only in metadata is unroutable — no conformant client reads metadata, they match on `description` alone — so it would rot silently and give a false impression of coverage. validate_skills.py and the smoke tests now assert every metadata trigger appears in the description, making the metadata index a derived view rather than a competitor. Current main satisfies this already; the check is a regression guard, verified to fail on an injected unroutable trigger. Tests 195 -> 212. skills/mcp-servers/SKILL.md gains the section explaining what the portable mcp.json ships versus what the reader opts into, and why Toolbox is excluded. Cherry-picked from the parallel branch on PR #4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and final cherry-pick from #4.
The gap it closes
Moving routing keywords out of
triggersand intodescriptionleft the metadata copy as a second source of truth with nothing keeping the two in step. A trigger that lives only in metadata is unroutable — no conformant client reads metadata, they match ondescriptionalone — so it rots silently while still looking like coverage.validate_skills.pyand the smoke tests now assert every metadata trigger appears in the description. That makes the metadata index a derived view rather than a competing source of truth.mainalready satisfies the invariant — this is a pure regression guard, no fixes needed.Also adds the
skills/mcp-servers/SKILL.mdsection on what the portablemcp.jsonships versus what the reader opts into, and why Toolbox is excluded.Why cherry-pick rather than merge #4
#4 is
CONFLICTING. Merging it would deleteCHANGELOG.md(-109), deleteskills/mcp-servers/references/agent-plugins-mcp.md(-89), revert the version to 0.1.0, and revert the routing disambiguation clauses in eight skills. Its genuinely additive content is now fully extracted across #8 and this PR.