Repository navigation
Ignore popup selection after disabling Combobox or Multiselect - #1171
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1170.
Problem
disabledtotruewhile the application keeps the popup open.Watch the Combobox reproduction. It uses the repository's widget styles.
An async update can disable the outer control while the user is choosing an option. The application owns the popup's visibility when it supplies
open. Both selection handlers now check the current disabled state before applying an option, following the existing guard in DropdownList.I found this interaction while testing component state transitions in Anta, then reproduced it separately in React Widgets.
Validation
Both regressions fail on current master and pass with the fix. Real Chrome clicks confirm that both widgets keep Apple and emit zero change events after disabling. The package's lint check and all 137 enabled tests pass.
AI-assisted implementation and testing.