Repository navigation
Test Node 25 and 26 in CI - #375
Merged
Merged
Conversation
Extend all test matrices with Node 25 and 26 while retaining the existing supported versions. Run lint and valid-string checks on Node 26 so the latest-version jobs exercise the upcoming LTS release.
Only the latest odd version is supported by Node, 23 is not LTS.
This pulls in a modification that runs all of the relevant Intl.DateTimeFormat tests, solving the log messages about tests that weren't found.
ptomato
force-pushed
the
update-node-24-26
branch
3 times, most recently
from
September 22, 2026 17:40
ae1753c to
64202ee
Compare
This is so that I can see what exactly we're working with in CI, rather than guessing whether I have the same version installed locally.
ptomato
force-pushed
the
update-node-24-26
branch
3 times, most recently
from
September 22, 2026 18:22
4ace53b to
1ba814f
Compare
Add a before-26.x file, delete the DurationFormat-specific tests as we don't run them, and move things around appropriately as Node LTS versions were updated with later ICU/CLDR releases. I cannot figure out why the Node 14 job is running a different test glob than all the other jobs! It runs 5555 tests, including the DurationFormat ones, whereas all the other jobs run 5720 tests. Perhaps the glob module works differently.
ptomato
force-pushed
the
update-node-24-26
branch
from
September 22, 2026 18:31
1ba814f to
b6c0976
Compare
ptomato
approved these changes
Sep 22, 2026
ptomato
left a comment
ptomato
left a comment
Contributor
There was a problem hiding this comment.
Well, fixing up the expected failure files was a wild ride!
There was a bug that we previously thought was CLDR-specific, but ends up only being present in Node 18 through 25, and fixed in 26 despite it having the same CLDR version.
Also I cannot figure out why the Node 14 job is running a different test glob than the others, but that's for another time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Node 25 and 26 tests in CI.