Repository navigation
Allow replacing Temporal.Now in the library export - #377
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363.
The library exports
Temporalas an ES module namespace, so a test clock cannot replaceTemporal.Nowand restore it afterward. The export now preserves the existing properties and givesNowthe same writable, non-enumerable, configurable descriptor as native Temporal. The regression test replacesNow, reads the fake clock, and restores the original descriptor.On Node 26, all 608 Jest tests, lint, type checks, and the valid-strings test passed. I also checked replacement and restoration through both built package entry points. Test262 debug, production, and ES5 runs produced the same results as unchanged main, including the existing
intl402/Temporal/ZonedDateTime/links.jsfailure.