Repository navigation
Conversation
Author
|
The upstream CI and CodeQL workflows are waiting for approval. Could you approve them when reviewing this PR? The unchanged fork CI workflow passed the full tests, formatting, and TypeScript checks at the exact PR commit |
Member
|
Opting to remove hiding any keys in #151 instead. Ideally it'd throw, but I think that's a worse breaking change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format()can emit twofilename*parameters when a Unicode plain parameter and an explicit extended parameter differ in casing:The duplicate is invalid under RFC 6266 §4.1, and filename parameter names are case-insensitive under §4.3. Parsing the old output also selects the synthesized filename instead of the explicit value.
Extend the precedence rule from #144 to compare parameter names case-insensitively. Build the normalized lookup only when extended encoding is needed, and retain the original output casing, Latin-1 fallback values, and multipart behavior.
This is separate from the inherited-property fix in #149: its current head still reproduces this mixed-case defect. Both changes apply together without conflict and their combined suite passes.
Validation:
2a79734; all 217 tests pass after the fix on macOS arm64 with Node 22.23.5 and 25.9.0.npm testalso runs formatting and TypeScript checks; coverage is 100% for statements, branches, functions, and lines.npm run buildandgit diff --checkpass.d21ebaefor Node 22.23.4 and the workflow’slatestselection (27.0.0-alpha.0.1.1).Developed and validated with OpenAI Codex.