You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
normalizeType() throws instead of returning false for a malformed Content-Type header #100
typeis()/typeofrequest() throws an uncaught TypeError instead of returning false when the request has a Content-Type header whose type portion (everything before the first ;, after trimming optional whitespace) is empty — e.g. a header value of ; or one that's entirely whitespace.
TypeError: argument string is required
at Object.test (node_modules/media-typer/index.js:87:11)
at normalizeType (index.js:239:16)
at typeis (index.js:54:13)
at typeofrequest (index.js:140:10)
Root cause
normalizeType() (index.js:235-240) calls content-type's parse(value, { parameters: false }).type and then media-typer.test(type):
functionnormalizeType(value){if(!value)returnnullvartype=contentType.parse(value,{parameters: false}).typereturntyper.test(type) ? type : null}
Since content-type@2 became more lenient (jshttp/content-type#58), parse() no longer validates the extracted type before returning it — for a header like ;, it now returns type: '' instead of throwing its own invalid media type error like content-type@1.x used to. That empty string then reaches media-typer.test(), which treats falsy input as a usage error and throws, rather than returning false.
type-is@1.x guarded against exactly this class of failure — tryNormalizeType wrapped the equivalent call in a try/catch and returned null on any thrown error:
That protection was dropped somewhere in the 2.x rewrite (I believe around #95, which switched from media-typer.parse()/format() to content-type.parse() + media-typer.test()), so this class of malformed input is no longer caught.
Impact
Any app using type-is (directly, or via body-parser@2.x/express@5, both of which now depend on type-is@^2.0.0) will crash with an unhandled exception on a request that has a malformed-but-present Content-Type header and either a Content-Length or Transfer-Encoding header — regardless of what route or middleware is checking the content type. This is reachable pre-authentication on any endpoint that runs body-parser's json()/urlencoded().
I've verified this with a minimal reproduction against type-is@2.1.0 HEAD, and confirmed restoring a try/catch around the parse/test call (matching 1.x's behavior) fixes it without any other test regressions. Happy to open a PR with the fix and a regression test if useful.
Activity
blakeembrey commentedon Jul 23, 2026
Fixed with jshttp/media-typer#58. Great catch!