Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline 2.2 + 2.5–2.6 — cancellable model lifecycle, catalog integrity, and Android persistence wiring
This PR continues directly from #60 and makes the Engine model lifecycle safe under concurrent inference while making the model catalog authoritative and wiring Android persistence.
2.2 changes
closeModel(modelId)blocks new admissions, interrupts active native inference, cancels queued requests, waits for all admitted work to stop, and then unloads the model while keeping its installed artifact.closeModel()throughEngineHttpServerandEngineService.deleteModel()now performs the same close/interrupt/unload sequence before removing the installed artifact.2.5 changes
ModelDescriptorwith explicit artifactformat, trustedquantization, and catalog metadata./v1/modelsfrom deriving quantization from model IDs.markInstalled()to reference an existing catalog entry.2.6 changes
schema/DDL canonical and package it as Android assets.RuntimeClientcomposition root using app-privateContext.filesDirstorage.userDriver,projectDbFactory, and the runtime-managed project root.RealRuntimeClientbetweenMainActivityand the foreground runtime service.ProjectLockerunset until Android file-lock semantics have real instrumentation coverage.Remaining