Upgrade llama.cpp Java binding to 4.2.0 and adapt adapters and loader to new API - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
de.kherud:llama:4.2.0binding to ensure consistent GGUF compatibility and a request-oriented streaming API.modelVersion.Description
de.kherud:llama:4.2.0inengine/modelruntimeandengine/androidappand added clarifying comments about binding selection in the Android Gradle file.LlamaCppAdapterto the new parameters and constructor shapes by usingModelParameters().setModel(...).setCtxSize(...).setThreads(...).setThreadsBatch(...).setBatchSize(...).setUbatchSize(...).setGpuLayers(...)and callingLlamaModel(params)instead of the old constructor, and updatedmodelVersiontojava-llama.cpp-4.2.0.LlamaCppAdapterandAndroidLlamaCppAdapterto useInferenceParameters(prompt)withsetNPredict,setTemperature,setTopP, andsetTopK, and iteratemodel.generate(parameters)to stream token deltas as they arrive.ModelLoaderto introduce a privateloadInternalimplementation that accepts a nullableartifactPathand exposed two public overloads for normal id resolution and exact artifact loading.GgufRot13FixtureTestto constructModelParametersandInferenceParametersusing the new API shapes.Testing
./gradlew :engine:modelruntime:test, which executed the JVM unit tests includingGgufRot13FixtureTest, and the suite completed successfully (native inference checks are skipped when the platform lacks a native binary)../gradlew buildto verify compilation across modules, and the build completed successfully.Codex Task