[WIP] Resume from golden snapshot with durable data instead of cold booting from OCI images - #2715
Draft
supreme-gg-gg wants to merge 1 commit into
Draft
[WIP] Resume from golden snapshot with durable data instead of cold booting from OCI images#2715supreme-gg-gg wants to merge 1 commit into
supreme-gg-gg wants to merge 1 commit into
Conversation
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Substrate added the capability to resume from golden snapshot (FULL snapshots) with durable data (DATA snapshots) for
gVisorsandbox class. This PR switches resumes to use that instead of cold booting with DATA snapshot.I would expect this to improve performance with resumes across all harness. I'm currently running benchmarks to measure specific latency and response time improvements (or degradation). I am also going to document the possible impact of upgrade behaviour for FULL snapshots as part of this PR (i.e. specific factors that may result in failures).
Snapshot selection
Benchmark