fix: promote queued follow-ups through native RPC - #67
Draft
andrebrait wants to merge 2 commits into
Draft
andrebrait wants to merge 2 commits into
andrebrait wants to merge 2 commits into
Conversation
Owner
Review: blocked on the native command — not mergeable as-isThanks for the split-out work here. I reviewed Native dependency is genuinely missing
The web-side change itself reviews clean
Asks
Context: #64, #68 and #69 landed today, so inline delete confirmation and mobile Enter are already in |
3 tasks
Contributor
Author
|
Native implementation: can1357/oh-my-pi#11618. The combined changes were tested successfully in the isolated |
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
promote_queued_messageRPC command.Native dependency
Draft: do not merge until an OMP release provides
promote_queued_message. The native implementation is can1357/oh-my-pi#11618. Released OMP 18.1.16 and 18.1.17 do not support the command. The combined changes were tested successfully in an isolated deployment. Unsupported runtimes produce an error rather than sending a duplicate steering message.Verification
promoted: true, visibly changed to QUEUED STEER, and delivered the original correction exactly once withsteering: truebefore background Bash completion.npm run release:check: typecheck, lint, 634 tests passed (one Windows-only test skipped on Linux), and production build passed.Review follow-up
Queue transitions now execute synchronously in event/effect handlers; React receives immutable queue snapshots, not replayable functional updaters with promotion side effects. The batched removal/ACK and delivery-before-ACK paths are covered under StrictMode.