Repository navigation
Conversation
sanmai
approved these changes
Oct 22, 2026
sanmai
left a comment
Collaborator
There was a problem hiding this comment.
Good idea. Would you rather wrap it with unit tests, or would you prefer for someone to take over?
Author
|
Apologies @sanmai for the delayed response, was somewhat busy these days ! Thanks for the update ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the usage of https://liquidjs.com/filters/date.html#TimeZone and liquid within marketing automation systems.
The optional specification of a IANA timezone identifier for the
| datefilter is essential e.g. in e-mail templates containing liquid which require you to forward date / time data in the timezone of the e-mail recipient.Using an IANA timezone identifier also ensures that daylight saving time is handled automatically, which is not the case if you specify the "hardcoded" offset via the
%zformat directive.Felt like this was missing in this package.