Skip to content

getting stuck in root dir #4

Description

@BigMacTaylor

At risk of sounding redundant, while 64107f9 keeps nim from raising OSErrors it ignores the root problem.
Which is that calling parentDir() on root returns a empty string. NOT "/". Therefore if parent != currentDir: returns true.

A fix would be:
if parent != currentDir and parent != "":
or even better:
if not isRootDir(currentDir):

      else:
        let parent = parentDir(currentDir) # returns empty string
        if parent != currentDir: # returns true
          currentDir = parent
          scanDir(currentDir)
          applyFilter()

Hope this didn't come off harsh. I like project and wish it well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions