feat(displays): clarify custom alignment picker labels - #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the custom display alignment pickers by separating horizontal and vertical option ordering and switching the labels to directional wording.
This updates the settings UI so horizontal options read left-to-right, vertical options read top-to-bottom, and the symbol glyphs are composed in code rather than embedded in localized strings.
Closes #116.
Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/KeyboardVisualizerAlignmentPlacementTestsRun project commands from
Apps/Keyty.UI Changes
Documentation
Release Notes
Custom display alignment settings now use clearer directional labels and a more intuitive option order.