Repository navigation
Clarify Caveat remote-mismatch diagnostic wording - #4
Merged
Merged
Conversation
Keep the existing check identity, severity and state while clarifying that the diagnostic does not establish sync operation success, cause or impact. Cover unchanged cases and v5-v9 projections with an in-memory command runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveatの同期診断がremote_mismatchを返した時、現在の文面「caveat sync failed」は同期操作そのものの失敗とも読めます。製品がCaveat、部品がsync、理由がremote_mismatchの時だけ、共有先HEADと端末HEADの不一致を観測したことと、同期操作の成否・原因・実害が未確認であることを表示します。
checkのstatus、fingerprint、severity、reason、count、時刻を保持し、他条件の文面も維持します。共通projectionを使うv5〜v9の将来reportに届きます。
検証: 隔離HOME/PATHと偽runCommandによるfocused試験20件成功。v5〜v9 × 3模擬platform × 7条件の105ケースを各wire validatorへ通しました。変更ファイルの構文、通常make lint-js、差分空白検査も成功。通常PR CI 39105660698（attempt 1）はLinux・macOS・Windowsのmake ciと最終gateがすべて成功。各OSのログで新規回帰試験7件の成功を確認しました。PR検査用merge commitと候補HEADのtreeも一致しています。
実同期欠陥・実害・修理要否は未確定です。host導入・実利用受入・private診断保存機能は後続の別工程です。